fix: sensor views shown without PSLab device #1326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CloudyPadmal
added
the
Status: Review Required
abhinavraj23
reviewed
Aug 4, 2018
| @Override | ||
| public void onClick(View v) { | ||
| if (play) { | ||
| if (play & scienceLab.isConnected()) { |
Member
There was a problem hiding this comment.
@CloudyPadmal Is there a specific reason to use single & operator and not && , I think && should be better.
Collaborator
Author
There was a problem hiding this comment.
Ahh yes! I'll make the changes! 👍
CloudyPadmal
force-pushed
the
senavail
branch
3 times, most recently
from
09da99c to
437a0ac
Compare
Contributor
|
@CloudyPadmal there's some codacy issues. |
Collaborator
Author
|
Now Codacy build is passing! |
cweitat
approved these changes
Aug 8, 2018
CloudyPadmal
removed
the
Status: Review Required
neel1998
pushed a commit
to neel1998/pslab-android
that referenced
this pull request
Jul 30, 2019
fix: sensor views shown without PSLab device
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1283
Changes:
Screenshot/s for the changes:
Checklist: [Please tick following check boxes with
[x]if the respective task is completed]strings.xml,dimens.xmlandcolors.xmlwithout hard-coding themstrings.xml,dimens.xmlorcolors.xmlAPK for testing:
sensors.apk.zip