refactor: updated bottomsheet of multimeter #1330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhinavraj23
added
the
Status: Review Required
abhinavraj23
requested review from
Avjeet,
CloudyPadmal and
harsh-2711
and removed request for
CloudyPadmal
CloudyPadmal
requested changes
Aug 5, 2018
app/src/main/res/values/strings.xml
Outdated
| <string name="multimeter_dialog_description">\u2022 To measure the voltage directly connect the power source(eg PV1,PV2 and PV3) to the channel pins as shown in the figure.\n\n\u2022 Similarly to measure frequency or count pulse connect SQ1,SQ2,SQ3 or SQ4 pins to ID1,ID2,ID3 or ID4.</string> | ||
| <string name="multimeter_dialog_description">\u2022 To measure the voltage directly connect the power source(eg PV1,PV2 and PV3) to the channel pins as shown in the figure.\n\n\u2022 Similarly to measure frequency or count pulse connect SQ1,SQ2,SQ3 or SQ4 pins to ID1,ID2,ID3 or ID4.\n\n | ||
| <b>Different Sections</b>\n\n | ||
| <b>Resistance:</b> Measures the resistance of the element connected to the SEN pin of the PSLab device.\n\n |
Collaborator
There was a problem hiding this comment.
Shouldn't it be "element connected between SEN pin and GND pins"?
Member
Author
|
@CloudyPadmal Changes done as requested, @harsh-2711 @Avjeet please review |
CloudyPadmal
requested changes
Aug 5, 2018
app/src/main/res/values/strings.xml
Outdated
| <string name="multimeter_dialog_description">\u2022 To measure the voltage directly connect the power source(eg PV1,PV2 and PV3) to the channel pins as shown in the figure.\n\n\u2022 Similarly to measure frequency or count pulse connect SQ1,SQ2,SQ3 or SQ4 pins to ID1,ID2,ID3 or ID4.\n\n | ||
| <b>Different Sections</b>\n\n | ||
| <b>Resistance:</b> Measures the resistance of the element connected between the SEN and GND pin of the PSLab device.\n\n | ||
| <b>Capacitance:</b> Measures the capacitance of the element connected to the CAP pin of the PSLab device.\n\n |
Collaborator
There was a problem hiding this comment.
This should also be changed like that, between CAP and GND
app/src/main/res/values/strings.xml
Outdated
| <b>Different Sections</b>\n\n | ||
| <b>Resistance:</b> Measures the resistance of the element connected between the SEN and GND pin of the PSLab device.\n\n | ||
| <b>Capacitance:</b> Measures the capacitance of the element connected to the CAP pin of the PSLab device.\n\n | ||
| <b>Voltage:</b> Measures the voltage of any elements connect across any of the channel pins and other pins such as AN8.\n\n |
Collaborator
There was a problem hiding this comment.
Similarly in this and the rest. We have to connect one end to measuring pin and the other end to GND
Member
Author
|
@CloudyPadmal Changes done 👍 @harsh-2711 @Avjeet Please review. |
CloudyPadmal
approved these changes
Aug 7, 2018
CloudyPadmal
removed
the
Status: Review Required
neel1998
pushed a commit
to neel1998/pslab-android
that referenced
this pull request
Jul 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1306
Changes:updated bottomsheet of multimeter
Screenshot/s for the changes: [Add screenshot/s of the layout where you made changes or a
*.gifcontaining a demonstration]Checklist: [Please tick following check boxes with
[x]if the respective task is completed]strings.xml,dimens.xmlandcolors.xmlwithout hard-coding themstrings.xml,dimens.xmlorcolors.xmlAPK for testing: [Compress the
app-debug.apkfile into a<feature>.raror<feature>.zipfile and upload it here]bottomsheet.apk.zip