Adding Bottomsheet guide to the barometer #1339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@CloudyPadmal @abhinavraj23 @Avjeet @harsh-2711 Please review it. |
CloudyPadmal
requested changes
Aug 8, 2018
app/src/main/res/values/strings.xml
Outdated
| <string name="barometer_description">Measures the pressure of the atmosphere</string> | ||
| <string name="barometer">Barometer</string> | ||
| <string name="barometer_description">Measures the atmospheric pressure</string> | ||
| <string name="barometer_intro">\u2022 The Barometer can be used to measure the atmospheric pressure. This instruments |
Collaborator
There was a problem hiding this comment.
The Barometer can be used to measure Atmospheric pressure. This instrument
app/src/main/res/values/strings.xml
Outdated
| <string name="barometer_description">Measures the atmospheric pressure</string> | ||
| <string name="barometer_intro">\u2022 The Barometer can be used to measure the atmospheric pressure. This instruments | ||
| is compatible with either the built in pressure sensor on any android device or the BMP-180 pressure sensor.\n\n | ||
| \u2022 If you want to use the sensor BMP-180, connect the sensor to PSLab device as shown below</string> |
Collaborator
There was a problem hiding this comment.
as shown in the figure
app/src/main/res/values/strings.xml
Outdated
| \u2022 If you want to use the sensor BMP-180, connect the sensor to PSLab device as shown below</string> | ||
| <string name="barometer_desc">\u2022 The above pin configuration has to be same except for the pin | ||
| GND. GND is meant for Ground and any of the PSLab device GND pins can be used since they are common.\n\n | ||
| \u2022 Select sensor by going to the Configure tab from the bottom navigation bar and choose BMP-180 in the drop down menu under Select Sensor.</string> |
app/src/main/res/values/strings.xml
Outdated
| \u2022 If you want to use the sensor BMP-180, connect the sensor to PSLab device as shown below</string> | ||
| <string name="barometer_desc">\u2022 The above pin configuration has to be same except for the pin | ||
| GND. GND is meant for Ground and any of the PSLab device GND pins can be used since they are common.\n\n | ||
| \u2022 Select sensor by going to the Configure tab from the bottom navigation bar and choose BMP-180 in the drop down menu under Select Sensor.</string> |
Collaborator
There was a problem hiding this comment.
Can we emphazise "Configure" and "Select Sensor"?
Contributor
Author
|
@CloudyPadmal I'll make the requested changes |
Adding bottomsheet to barometer Adding bottomsheet to barometer experiment Correcting grammatical errors and enhansing text
CloudyPadmal
approved these changes
Aug 8, 2018
neel1998
pushed a commit
to neel1998/pslab-android
that referenced
this pull request
Jul 30, 2019
Adding bottomsheet to barometer Adding bottomsheet to barometer experiment Correcting grammatical errors and enhansing text
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1245
Changes:
Added bottomsheet to barometer experiment
Screenshot/s for the changes:
Checklist: [Please tick following check boxes with
[x]if the respective task is completed]strings.xml,dimens.xmlandcolors.xmlwithout hard-coding themstrings.xml,dimens.xmlorcolors.xmlAPK for testing:
barometer_bottomsheet.zip