Skip to content

added auto hide top bar #1413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2018
Merged

added auto hide top bar #1413

merged 1 commit into from
Oct 21, 2018

Conversation

@hrprt96
Copy link
Contributor

@hrprt96 hrprt96 commented Oct 10, 2018

Fixes #1386

Changes: On devices with horizontal screen implement auto-hiding top bar

Screenshot/s for the changes:
image1
image2
image3

Checklist:

  • I have used resources from strings.xml, dimens.xml and colors.xml without hard-coding them
  • No modifications done at the end of resource files strings.xml, dimens.xml or colors.xml
  • I have reformatted code in every file included in this PR [CTRL+ALT+L]
  • My code does not contain any extra lines or extra spaces
  • I have requested reviews from other members

APK for testing:
app-debug.zip

Avjeet
Avjeet approved these changes Oct 11, 2018
View reviewed changes
Copy link
Contributor

@Avjeet Avjeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hrprt96 Thnx for the PR, next time while uploading the apk file rename it to something else than apk_debug, other than that PR is fine.

@Avjeet Avjeet requested a review from CloudyPadmal October 11, 2018 09:01
@CloudyPadmal CloudyPadmal merged commit c9b2ca2 into fossasia:development Oct 21, 2018
neel1998 pushed a commit to neel1998/pslab-android that referenced this pull request Jul 30, 2019
@hrprt96 @CloudyPadmal
added auto hide top bar (fossasia#1413)
8f25eb4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CloudyPadmal CloudyPadmal CloudyPadmal approved these changes

@harsh-2711 harsh-2711 Awaiting requested review from harsh-2711

@abhinavraj23 abhinavraj23 Awaiting requested review from abhinavraj23

+1 more reviewer

@Avjeet Avjeet Avjeet approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@hrprt96 hrprt96

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hrprt96 @CloudyPadmal @Avjeet