feat: Improve UI of FAQs #1451
feat: Improve UI of FAQs #1451
Conversation
| } | ||
|
|
||
| @Override | ||
|
|
There was a problem hiding this comment.
Why is this annotation removed? Please add it back.
| <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android" | ||
| android:layout_width="match_parent" | ||
| android:layout_height="wrap_content" | ||
| android:background="#fafafa" |
There was a problem hiding this comment.
Use resources for colors and strings without hardcoding them
There was a problem hiding this comment.
@CloudyPadmal I've made the changes as per requested.
|
Please update the branch you are working on. It seems to have lot of changes from the main repo. |
|
@CloudyPadmal, I've updated my working branch as per requested. |
| else return value; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Hi! Please do not make any modifications to files other than the ones addressed in the issue. Please revert this new line deletion entry.
There was a problem hiding this comment.
@CloudyPadmal I apologize, it might have happened while I was resolving the merge conflicts. Also could you please tell me what to do as the curly brace was on line 136 and is still on line 136 and the code is reformatted, so what should I do ??
There was a problem hiding this comment.
This change relates to a deletion of a new line.
There was a problem hiding this comment.
@CloudyPadmal I've reverted the changes, however, I tried but I was not able to squash the
commits into a single commit.
Princejhabak
force-pushed
the
faq
branch
2 times, most recently
from
e829913 to
b945660
Compare
* feat: Add checkable behavior to menu items under other category in the navigation drawer * feat: Add back button in the toolbar * feat: Improve UI of FAQs * feat: Improve UI of FAQs
2 participants
Fixes #1449
Changes: [Add here what changes were made in this issue and if possible provide links.]
Screenshot/s for the changes:
Checklist:
strings.xml,dimens.xmlandcolors.xmlwithout hard-coding themstrings.xml,dimens.xmlorcolors.xmlAPK for testing:
faq.zip