Skip to content

Conversation

@CloudyPadmal
Copy link
Collaborator

@CloudyPadmal CloudyPadmal commented Dec 12, 2018

Fixes #1469

Changes:

  • Added play and pause feature. Now the whole graph is displayed once the logged data screen is opened.

Screenshot/s for the changes:

1 2 3
1 3 2

Checklist: [Please tick following check boxes with [x] if the respective task is completed]

  • I have used resources from strings.xml, dimens.xml and colors.xml without hard-coding them
  • No modifications done at the end of resource files strings.xml, dimens.xml or colors.xml
  • I have reformatted code in every file included in this PR [CTRL+ALT+L]
  • My code does not contain any extra lines or extra spaces
  • I have requested reviews from other members

APK for testing:
LuxPlay.apk.zip

@CloudyPadmal CloudyPadmal added Status: Review Required Requested reviews from peers and maintainers Feature New addition to the existing app labels Dec 12, 2018
@mariobehling
Copy link
Member

I think we also need a stop button next to the play button. Pause button: Display pauses. Stop button: Display stops and when the user presses play again, it starts again from the beginning.

So, I am merging this here as the first step.

@mariobehling mariobehling merged commit 6a59a3d into fossasia:development Dec 12, 2018
@CloudyPadmal CloudyPadmal added Status: Review Required Requested reviews from peers and maintainers and removed Status: Review Required Requested reviews from peers and maintainers labels Dec 13, 2018
neel1998 pushed a commit to neel1998/pslab-android that referenced this pull request Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature New addition to the existing app

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants