feat: implementing barometer #1475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CloudyPadmal
added
Status: Review Required
CloudyPadmal
requested review from
Avjeet,
abhinavraj23,
cweitat,
harsh-2711 and
mariobehling
Collaborator
Author
|
I'll have to merge the changes from #1472 into this one once it gets merge. (Stop button etc.) |
mariobehling
approved these changes
Dec 14, 2018
Member
|
Please also add the screenshots to the docs img folder. |
CloudyPadmal
force-pushed
the
barometer
branch
from
cbb2c11 to
a03a0f6
Compare
Contributor
|
@CloudyPadmal some codacy issues. |
Contributor
|
Also spelling of barometer. Is joined, not separated. |
Collaborator
Author
|
Thank you for the review @cweitat ! I'll update the PR with changes. 👍 |
CloudyPadmal
force-pushed
the
barometer
branch
from
e0ec166 to
5b3364f
Compare
Collaborator
Author
|
Hi @cweitat ! I've made the changes. Can you have a look? :D |
cweitat
approved these changes
Dec 16, 2018
CloudyPadmal
removed
the
Status: Review Required
neel1998
pushed a commit
to neel1998/pslab-android
that referenced
this pull request
Jul 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1331
Changes:
Screenshot/s for the changes:
Checklist:
strings.xml,dimens.xmlandcolors.xmlwithout hard-coding themstrings.xml,dimens.xmlorcolors.xmlAPK for testing:
BaroMeter.apk.zip