Skip to content

Conversation

@AsCress
Copy link
Collaborator

@AsCress AsCress commented Sep 14, 2025

Summary by Sourcery

New Features:

  • Support USB communication on Linux and macOS by registering DesktopUSBCommunicationHandler for these platforms

@AsCress AsCress requested a review from marcnause September 14, 2025 15:50
@AsCress AsCress self-assigned this Sep 14, 2025
@AsCress AsCress added Feature New addition to the existing app flutter labels Sep 14, 2025
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Sep 14, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The PR updates the dependency injection in locator.dart to include Linux and macOS under the desktop USB communication handler, ensuring USB support on newly supported platforms without altering existing Android or iOS logic.

Class diagram for updated CommunicationHandler registration

classDiagram
    class CommunicationHandler
    class AndroidUSBCommunicationHandler
    class DesktopUSBCommunicationHandler
    class IosNoOpCommunicationHandler
    CommunicationHandler <|-- AndroidUSBCommunicationHandler
    CommunicationHandler <|-- DesktopUSBCommunicationHandler
    CommunicationHandler <|-- IosNoOpCommunicationHandler
Loading

File-Level Changes

Change Details Files
Expanded desktop USB support to Linux and macOS
  • Added Platform.isLinux to the desktop handler condition
  • Added Platform.isMacOS to the desktop handler condition
lib/providers/locator.dart

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@AsCress AsCress enabled auto-merge (squash) September 14, 2025 15:52
@AsCress AsCress merged commit d27282e into fossasia:flutter Sep 14, 2025
13 checks passed
@github-actions
Copy link
Contributor

Build Status

Build successful. APKs to test: https://github.com/fossasia/pslab-app/actions/runs/17713373715/artifacts/4006819938.

Screenshots

Android Screenshots
iPhone Screenshots
iPad Screenshots

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature New addition to the existing app flutter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants