Skip to content

Add resue output format for check_output_format fct. #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 11, 2022
Merged

Add resue output format for check_output_format fct. #67

merged 1 commit into from
May 11, 2022

Conversation

@bjk7119
Copy link
Contributor

@bjk7119 bjk7119 commented May 10, 2022

Description

  • Add resue output format for check_output_format fct.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation update
  • Refactoring, Maintenance
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@bjk7119 bjk7119 added the chore [PR/Issue] Refactoring, maintenance the code label May 10, 2022
@bjk7119 bjk7119 requested a review from soimkim May 10, 2022 03:05
soimkim
soimkim reviewed May 10, 2022
View reviewed changes
@soimkim
Copy link
Contributor

soimkim commented May 10, 2022

#42 line, for _format, _ext in SUPPORT_FORMAT.items(): -> for _format, _ext in support_format.items():

@bjk7119 bjk7119 force-pushed the develop branch 2 times, most recently from 1797b30 to c510ede Compare May 11, 2022 01:32
@bjk7119 bjk7119 merged commit 8ee8e59 into main May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@soimkim soimkim soimkim approved these changes

Assignees

No one assigned

Labels

chore [PR/Issue] Refactoring, maintenance the code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bjk7119 @soimkim