Control relationships #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spec/serializer_spec.rb
Outdated
| }) | ||
| end | ||
|
|
||
| it 'allows to inclue data for relationships' do |
|
This looks great! The tests definitely make me happy. Any chance you'd like to add a small update to the |
Removed long-content attribute from relationship representation specs. Updated README.
|
@fotinakis thank you for your feedback. I've updated specs according to your suggestions and fixed the typo. I've also updated Please check when you have a moment. Thanks! |
|
Thanks for your contribution! This has been released in v0.11.0 of the gem. |
This was referenced Apr 27, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains changes from this PR + fixes I mentioned in the comments.
I've also added tests to make sure it's working as expected.