Add Env var to control cumulative test tokens generated per sequence #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abhishek <maurya.abhishek@ibm.com>
Signed-off-by: Abhishek <maurya.abhishek@ibm.com>
JRosenkranz
reviewed
Sep 10, 2025
tests/models/test_decoders.py
Outdated
| USE_DISTRIBUTED = os.environ.get("FMS_TEST_SHAPES_DISTRIBUTED", "0") == "1" | ||
| TIMING = os.environ.get("TIMING", "") | ||
|
|
||
| CUMULATIVE_TEST_TOKENS_PER_SEQUENCE = os.environ.get( |
Contributor
There was a problem hiding this comment.
we should wrap this in an int as the below statement will be doing "1024" // max_new_tokens
Contributor
Author
There was a problem hiding this comment.
@JRosenkranz Thanks for the review. Pushed the change.
Signed-off-by: Abhishek <maurya.abhishek@ibm.com>
Contributor
|
bot:test |
Contributor
Author
|
bot:test |
Contributor
Author
|
@JRosenkranz Spyre-ci test is successful now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Iterations to generate tokens request is controlled by
iters, currently the value assigns to1024 // max_new_tokenswhich caps the usage of max_new_tokens to 1024. To increase this added a new env varFMS_TEST_SHAPES_CUMULATIVE_TEST_TOKENS_PER_SEQUENCEto be used in test_decoders for the same.