Fix: Apprentice Small Employer Field Incorrectly Triggering Bootcamp Rules #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous fix (d07a3e2) incorrectly added ESMType=OET, ESMCode=2 to ALL learners with "Small employer #2" (column 32), including apprentices. This code should ONLY appear for Skills Bootcamp learners with "Small employer #1" (column 20). This caused R134 rule violations: "The programme type must be Skills Bootcamps for this Employment Status Monitoring Type" Changes: - Removed OET=2 block from column 32 (Small employer #2) - Column 20 (Small employer #1) correctly retains OET=2 Result: - Skills Bootcamp learners (ProgType=32) → SEM=1 + OET=2 ✓ - Apprentices (ProgType=25) → SEM=1 only ✓ Fixes R134 violations for 23 apprentices with Small employer #2. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Apprentice Small Employer Field Incorrectly Triggering Bootcamp Rules
Overview
This PR fixes a bug where apprentices with "Small employer #2" were incorrectly receiving Skills Bootcamp-specific employment status codes, causing R134 rule violations. The bug was introduced when we added support for "Small employer #1" (bootcamp learners only) – we accidentally applied the same codes to the apprentice field as well.
Tip
After merging, test with a dataset containing both apprentices with "Small employer #2" and bootcamp learners with "Small employer #1" to verify no R134 violations occur.
Changes
main.jsRemoved the incorrect
ESMType=OET, ESMCode=2block from the "Small employer #2" section (column 32).Before:
SEM=1+OET=2❌SEM=1+OET=2✓After:
SEM=1only ✓SEM=1+OET=2✓This resolves R134 violations for 23 apprentices who were incorrectly flagged with "The programme type must be Skills Bootcamps for this Employment Status Monitoring Type".
docs/Organised documentation and archived previous fix references to maintain a clear history of the small employer field implementations.
package.jsonVersion bump to 1.1.1 (though I notice this was already at 1.1.1 - you may want to bump to 1.1.2).
Summary
This is like discovering you've been putting "vegan" stickers on all the bacon sandwiches just because you successfully added them to the veggie wraps. The bootcamp learners needed their special badge, but we accidentally gave it to the apprentices too – who were rightfully confused about why they were being called something they're not.