Skip to content
This repository was archived by the owner on Apr 20, 2026. It is now read-only.

chore: swap generics on Project#124

Merged
mattsse merged 4 commits intomainfrom
klkvr/swap-generics
May 21, 2024
Merged

chore: swap generics on Project#124
mattsse merged 4 commits intomainfrom
klkvr/swap-generics

Conversation

@klkvr
Copy link
Copy Markdown
Member

@klkvr klkvr commented May 20, 2024

Changes order of generics on Project. We'll be doing a lot of Project<C> and most of the time we use the same ConfigurableArtifacts

Comment thread src/project_util/mod.rs
@@ -33,12 +33,15 @@ pub struct TempProject<T: ArtifactOutput = ConfigurableArtifacts, C: Compiler =
/// temporary workspace root
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here too? TempProject

Copy link
Copy Markdown
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse mattsse merged commit 5b44736 into main May 21, 2024
@DaniPopes DaniPopes deleted the klkvr/swap-generics branch June 5, 2024 16:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants