This repository was archived by the owner on Apr 20, 2026. It is now read-only.
more test in report/compiler.rs and Default trait for CompilerInput#19
Merged
Evalir merged 7 commits intofoundry-rs:mainfrom Nov 10, 2023
Merged
Conversation
Evalir
suggested changes
Nov 7, 2023
Contributor
Evalir
left a comment
Evalir
left a comment
There was a problem hiding this comment.
more tests always better
pending nits & ci
Contributor
Contributor
Author
|
Thank you for pinging me, going to check this ! |
Contributor
Author
|
sorry for the late time, does this look good to you ? |
mattsse
suggested changes
Nov 10, 2023
mattsse
approved these changes
Nov 10, 2023
Member
|
needs cargo +nightly fmt |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.