Skip to content
This repository was archived by the owner on Apr 20, 2026. It is now read-only.

chore(ci): harden workflow by setting default permission to read only#320

Merged
zerosnacks merged 4 commits intomainfrom
zerosnacks/harden-ci
Sep 15, 2025
Merged

chore(ci): harden workflow by setting default permission to read only#320
zerosnacks merged 4 commits intomainfrom
zerosnacks/harden-ci

Conversation

@zerosnacks
Copy link
Copy Markdown
Member

@zerosnacks zerosnacks commented Sep 15, 2025

Defines per action permissions scoping, defaulting to read only

RE:

      - uses: actions/checkout@v5
        with:
          persist-credentials: false

See: actions/checkout#485

This does not yet introduce pinning to hashes, I want to find a good way to maintain this first. Apparently Dependabot has a feature for this.

@zerosnacks zerosnacks marked this pull request as ready for review September 15, 2025 09:20
Comment thread .github/workflows/ci.yml
Comment on lines +95 to +96
persist-credentials: false
- uses: dtolnay/rust-toolchain@clippy
Copy link
Copy Markdown
Member Author

@zerosnacks zerosnacks Sep 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: this now uses @clippy in line with other Foundry crates & Foundry which is nightly + clippy shorthand

@zerosnacks zerosnacks marked this pull request as draft September 15, 2025 10:28
@zerosnacks zerosnacks changed the title chore(ci): harden workflow by setting permissions per job chore(ci): harden workflow by setting default permission to read only Sep 15, 2025
@zerosnacks zerosnacks marked this pull request as ready for review September 15, 2025 10:48
@zerosnacks zerosnacks merged commit bccbdb1 into main Sep 15, 2025
18 checks passed
@zerosnacks zerosnacks deleted the zerosnacks/harden-ci branch September 15, 2025 10:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants