Skip to content

fix: preserve pre release version #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 19, 2025
Merged

fix: preserve pre release version #340

merged 1 commit into from
Nov 19, 2025

Conversation

@grandizzy
Copy link
Contributor

@grandizzy grandizzy commented Nov 19, 2025

  • preserve version, including prerelease if any, and pass to svm-rs
  • needed in find_svm_installed_version to identify local binary and avoid installing it on each run
  • svm-rs logic to deal with looking up and installing prereleases in feat: support solc prereleases alloy-rs/svm-rs#176

@grandizzy grandizzy force-pushed the find-installed-prerelease branch from 29ff852 to 74b5e89 Compare November 19, 2025 05:41
@grandizzy grandizzy marked this pull request as ready for review November 19, 2025 05:45
@grandizzy grandizzy mentioned this pull request Nov 19, 2025
Merged
3 tasks
zerosnacks
zerosnacks approved these changes Nov 19, 2025
View reviewed changes
Copy link
Member

@zerosnacks zerosnacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

mattsse
mattsse approved these changes Nov 19, 2025
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should work I believe

@onbjerg onbjerg merged commit 8f1c61c into foundry-rs:main Nov 19, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattsse mattsse mattsse approved these changes

@zerosnacks zerosnacks zerosnacks approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@0xrusowsky 0xrusowsky Awaiting requested review from 0xrusowsky 0xrusowsky is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@grandizzy @mattsse @zerosnacks @onbjerg