fix: updates coding example and minor spelling/grammar fixes #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devtooligan
commented
Mar 7, 2022
| ## Contracts | ||
| ### stdError | ||
|
|
||
| This is a helper contract for errors and reverts in solidity. In `forge`, this contract is particularly helpful for the `expectRevert` cheatcode, as it provides all compiler builtin errors. |
Contributor
Author
There was a problem hiding this comment.
I was gonna capitalize Solidity but then thought maybe its better just to delete it...
devtooligan
commented
Mar 7, 2022
| import "forge-std/stdlib.sol"; | ||
| import "forge-std/Vm.sol"; | ||
| contract TestContract is DSTest, stdError { |
Contributor
Author
There was a problem hiding this comment.
This is the main change
ZeroEkkusu
reviewed
Mar 8, 2022
Collaborator
ZeroEkkusu
left a comment
ZeroEkkusu
left a comment
There was a problem hiding this comment.
Thanks! Looks good.
Requested a review from brock, although there's not much else to see here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intent of this pr is to fix a mistake in the first coding example:
No need to import stdError, and doing so throws:
Also, while I had the readme open I cleaned up a few very minor spelling/grammar things.