Skip to content

fix(stdlib): make variables not meant for end-users private #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 18, 2022
Merged

fix(stdlib): make variables not meant for end-users private #28

merged 1 commit into from
Mar 18, 2022

Conversation

@ZeroEkkusu
Copy link
Collaborator

@ZeroEkkusu ZeroEkkusu commented Mar 18, 2022

Does anyone use these?

abstract contract stdCheats {
    Vm constant vm_std_cheats = Vm(address(uint160(uint256(keccak256('hevm cheat code')))));
    StdStorage std_store_std_cheats;

Let's make them private so they don't pop up as suggestions (autocomplete). Better UX.

@ZeroEkkusu ZeroEkkusu requested a review from brockelmore March 18, 2022 13:47
brockelmore
brockelmore approved these changes Mar 18, 2022
View reviewed changes
Copy link
Member

@brockelmore brockelmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty ser

@brockelmore brockelmore merged commit 4bfb08b into foundry-rs:master Mar 18, 2022
@ZeroEkkusu ZeroEkkusu deleted the work1 branch March 18, 2022 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brockelmore brockelmore brockelmore approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ZeroEkkusu @brockelmore