chore: fix fmt & bump Vm.sol #756
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zerosnacks
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
klkvr,
mattsse and
onbjerg
as code owners
zerosnacks
commented
Nov 10, 2025
Comment on lines
-2363
to
-2369
| function expectEmitAnonymous( | ||
| bool checkTopic0, | ||
| bool checkTopic1, | ||
| bool checkTopic2, | ||
| bool checkTopic3, | ||
| bool checkData | ||
| ) external; |
Member
Author
There was a problem hiding this comment.
cc @0xrusowsky is this an expected change or a regression?
Contributor
There was a problem hiding this comment.
mmmm i'd say expected but how do we feel about it?
Member
Author
There was a problem hiding this comment.
Stylistically I prefer the multiline as we had before above a certain threshold (like >= 4 args) but not sure what the logic is
I think the rule we apply now simply looks at line length correct?
onbjerg
approved these changes
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: https://github.com/foundry-rs/forge-std/actions/runs/19230711588