chore: eslint -> biome + enhance types + codeql #7
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the project from ESLint to Biome for linting and formatting, while also enhancing TypeScript type definitions for EIP-1193 and EIP-6963 standards. The changes improve type safety by replacing generic any types with more specific types and adding proper event type definitions.
Key changes:
- Replaced ESLint with Biome for linting and formatting
- Enhanced EIP-1193 and EIP-6963 type definitions with stricter typing
- Added null safety checks in entry point
- Updated code style to match Biome's formatting conventions
Reviewed Changes
Copilot reviewed 11 out of 13 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Replaced ESLint dependencies with Biome and updated npm scripts |
| eslint.config.js | Removed ESLint configuration file |
| biome.jsonc | Added Biome configuration with formatting and linting rules |
| src/types.ts | Enhanced type definitions for EIP-1193/EIP-6963 with specific event types and generics |
| src/main.tsx | Added null check for root element before rendering |
| src/App.tsx | Applied formatting changes and improved type safety with stricter types |
| vite.config.ts | Applied formatting changes (import ordering, template literals) |
| src/styles/*.css | Applied Biome formatting to CSS files |
| .husky/pre-commit | Added pre-commit hook |
| .github/workflows/ci.yml | Added formatting and linting checks to CI pipeline |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 11 out of 13 changed files in this pull request and generated 4 comments.
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ndry-rs/browser-wallet into zerosnacks/replace-eslint-with-biome
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 13 out of 15 changed files in this pull request and generated 2 comments.
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 14 out of 16 changed files in this pull request and generated no new comments.
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
zerosnacks
changed the title
No description provided.