-
Notifications
You must be signed in to change notification settings - Fork 0
feat: E2E transaction signing and submitting flow #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the Foundry browser wallet interface to add transaction signing/sending capabilities and polling for pending transactions from a local API server. The changes include removing custom Vite build plugins, adding API communication utilities, and restructuring the UI layout.
- Removed custom session token banner plugin from Vite config and simplified server configuration
- Added API helper functions and type definitions for client-server communication
- Implemented polling mechanism to fetch and handle pending transactions from local server
- Enhanced UI with new styling, transaction status display, and sign/send functionality
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| vite.config.ts | Removed custom plugin for session token banner and simplified server port configuration |
| src/utils/types.ts | Added API response types and transaction-related type definitions |
| src/utils/helpers.ts | Added API communication helpers, JSON rendering utilities, and exported chain utilities |
| src/styles/global.css | Updated styling for buttons, selects, and added pre-wrap for JSON display |
| src/styles/App.css | Restructured layout classes and added new component-specific styles |
| src/App.tsx | Major refactor adding transaction polling, signing/sending logic, and enhanced UI |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 6 out of 7 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 6 out of 7 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Adds E2E flow
Closes: #4