Skip to content

chore(script): avoid cloning script sequences when writing sensitive output #12085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 15, 2025
Merged

chore(script): avoid cloning script sequences when writing sensitive output #12085

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c69f539
chore(script): avoid cloning script sequences when writing sensitive …
Bilogweb3 Oct 13, 2025
65f6b79
Update sequence.rs
Bilogweb3 Oct 13, 2025
691c8cf
Update multi_sequence.rs
Bilogweb3 Oct 13, 2025
9206c26
Update sequence.rs
Bilogweb3 Oct 13, 2025
5db1f8e
Update multi_sequence.rs
Bilogweb3 Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions crates/script-sequence/src/sequence.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,8 @@ pub struct SensitiveScriptSequence {
pub transactions: VecDeque<SensitiveTransactionMetadata>,
}

impl From<ScriptSequence> for SensitiveScriptSequence {
fn from(sequence: ScriptSequence) -> Self {
impl From<&ScriptSequence> for SensitiveScriptSequence {
fn from(sequence: &ScriptSequence) -> Self {
Self {
transactions: sequence
.transactions
Expand Down Expand Up @@ -99,31 +99,31 @@ impl ScriptSequence {
return Ok(());
}

let Some((path, sensitive_path)) = self.paths.clone() else { return Ok(()) };

self.timestamp = now().as_millis();
let ts_name = format!("run-{}.json", self.timestamp);

let sensitive_script_sequence: SensitiveScriptSequence = self.clone().into();
let sensitive_script_sequence = SensitiveScriptSequence::from(&*self);

let Some((path, sensitive_path)) = self.paths.as_ref() else { return Ok(()) };

// broadcast folder writes
//../run-latest.json
let mut writer = BufWriter::new(fs::create_file(&path)?);
let mut writer = BufWriter::new(fs::create_file(path)?);
serde_json::to_writer_pretty(&mut writer, &self)?;
writer.flush()?;
if save_ts {
//../run-[timestamp].json
fs::copy(&path, path.with_file_name(&ts_name))?;
fs::copy(path, path.with_file_name(&ts_name))?;
}

// cache folder writes
//../run-latest.json
let mut writer = BufWriter::new(fs::create_file(&sensitive_path)?);
let mut writer = BufWriter::new(fs::create_file(sensitive_path)?);
serde_json::to_writer_pretty(&mut writer, &sensitive_script_sequence)?;
writer.flush()?;
if save_ts {
//../run-[timestamp].json
fs::copy(&sensitive_path, sensitive_path.with_file_name(&ts_name))?;
fs::copy(sensitive_path, sensitive_path.with_file_name(&ts_name))?;
}

if !silent {
Expand Down
6 changes: 3 additions & 3 deletions crates/script/src/multi_sequence.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,9 @@ pub struct SensitiveMultiChainSequence {
}

impl SensitiveMultiChainSequence {
fn from_multi_sequence(sequence: MultiChainSequence) -> Self {
fn from_multi_sequence(sequence: &MultiChainSequence) -> Self {
Self {
deployments: sequence.deployments.into_iter().map(|sequence| sequence.into()).collect(),
deployments: sequence.deployments.iter().map(SensitiveScriptSequence::from).collect(),
}
}
}
Expand Down Expand Up @@ -115,7 +115,7 @@ impl MultiChainSequence {

self.timestamp = now().as_millis();

let sensitive_sequence = SensitiveMultiChainSequence::from_multi_sequence(self.clone());
let sensitive_sequence = SensitiveMultiChainSequence::from_multi_sequence(&*self);

// broadcast writes
//../Contract-latest/run.json
Expand Down
Loading