-
Notifications
You must be signed in to change notification settings - Fork 2.2k
feat(anvil): add /eth/v1/beacon/blobs
beacon endpoint
#12182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Implemented the `anvil_getBlobsByBlockId` function in the Eth API to retrieve blobs by block ID and versioned hashes filtering option. - Created a new HTTP handler for the Beacon API to process requests for blobs. - Added integration test to validate the new endpoint and its functionality, including filtering by versioned hashes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may be worthy to deprecate (completely remove before the next release) /eth/v1/beacon/blob_sidecars
as it's already obsolete.
PS: I haven't removed it so far, awaiting your feedback...
|
||
// Get the blob sidecars using existing EthApi logic | ||
match api.anvil_get_blob_sidecars_by_block_id(block_id) { | ||
Ok(Some(sidecar)) => BeaconResponse::with_flags( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once /eth/v1/beacon/blob_sidecars
is deprecated, BeaconResponse
struct helper can be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you, can you pls check CI, the newly added test_beacon_api_get_blobs
test fails with
thread 'tokio-runtime-worker' has overflowed its stack
fatal runtime error: stack overflow, aborting
https://github.com/foundry-rs/foundry/actions/runs/18636701613/job/53128861516#step:14:1877
this is likely blob deserde issue |
Hmm I think the last commit (0f7c552) actually fixed the problem. I guess the failure is due to GitHub CI😅 https://github.com/foundry-rs/foundry/actions/runs/18648981612/job/53162399230?pr=12182 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Motivation
Close #12181
Solution
anvil_getBlobsByBlockId
in the Eth API to retrieve blobs by block ID and versioned hashes filtering option./eth/v1/beacon/blobs
routePR Checklist
/eth/v1/beacon/blob_sidecars
should be removed)