chore: Remove redundant Bytes inner conversions in fork and mem backends #12199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
phrwlk
commented
Oct 20, 2025
phrwlk
commented
- Replaced code.clone().0.into() with code.clone() in crates/anvil/src/eth/backend/fork.rs
- Replaced code.0.into() with code in crates/anvil/src/eth/backend/mem/mod.rs
- Rationale: alloy_primitives::Bytes already matches the target field types; extracting the inner bytes::Bytes and converting back via .into() is unnecessary and obscures intent. Using the original Bytes directly is clearer and avoids redundant wrapping.
phrwlk
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
mattsse,
onbjerg and
zerosnacks
as code owners
onbjerg
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.