Skip to content

Conversation

grandizzy
Copy link
Collaborator

@grandizzy grandizzy commented Oct 21, 2025

Motivation

Backtrace:
  at ExternalMathLib.div
  at LibraryConsumer.externalDivide
  at LibraryBacktraceTest.testExternalDivisionByZero

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@grandizzy grandizzy marked this pull request as ready for review October 21, 2025 06:54
zerosnacks
zerosnacks previously approved these changes Oct 21, 2025
Copy link
Member

@zerosnacks zerosnacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

Copy link
Contributor

@0xrusowsky 0xrusowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we update the verbosity flag docs so that the new behavior is reflected in the foundry book?

u want to look for all occurences of "Print execution and setup traces for all tests, including storage changes."

and maybe change them for something like:
"Print execution and setup traces for all tests, including storage changes and backtraces with line numbers."

wdyt?

0xrusowsky
0xrusowsky previously approved these changes Oct 21, 2025
@0xrusowsky 0xrusowsky enabled auto-merge October 21, 2025 08:11
@0xrusowsky 0xrusowsky added this pull request to the merge queue Oct 21, 2025
Merged via the queue into foundry-rs:master with commit 27a5d39 Oct 21, 2025
15 checks passed
@github-project-automation github-project-automation bot moved this to Done in Foundry Oct 21, 2025
grandizzy added a commit to grandizzy/foundry that referenced this pull request Oct 21, 2025
* fix(forge): show backtrace line only on -vvvvv

* fix tests

* Update docs

* Fix

---------

Co-authored-by: 0xrusowsky <90208954+0xrusowsky@users.noreply.github.com>
grandizzy added a commit that referenced this pull request Oct 22, 2025
* fix(fmt): inline call options when they fit (#12172)

* fix(fmt): inline call options when they fit

* fix: ensure closure only when extra box is opened

* fix(anvil): get account info from db when node block > fork block (#12175)

fix(anvil): return account info from db when requested block > fork block

* fix(fmt): do not add underscores on fractional part with exponent (#12195)

* fix(fmt): do not add underscores on fractional part with exponent

* Update crates/fmt/src/state/common.rs

Co-authored-by: DaniPopes <57450786+DaniPopes@users.noreply.github.com>

---------

Co-authored-by: grandizzy <38490174+grandizzy@users.noreply.github.com>
Co-authored-by: DaniPopes <57450786+DaniPopes@users.noreply.github.com>

* fix(forge): show backtrace line only on -vvvvv (#12211)

* fix(forge): show backtrace line only on -vvvvv

* fix tests

* Update docs

* Fix

---------

Co-authored-by: 0xrusowsky <90208954+0xrusowsky@users.noreply.github.com>

* chore: bump v1.4.3 (#12213)

* chore: fix tests

* chore: fix clippy (#12167)

* fix(coverage): do not account abstract contract items (#12202)

* fix(coverage): exclude only virtual fns without impl (#12216)

---------

Co-authored-by: 0xrusowsky <90208954+0xrusowsky@users.noreply.github.com>
Co-authored-by: DaniPopes <57450786+DaniPopes@users.noreply.github.com>
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

bug(forge): forge test -vvv greedy memory

3 participants