chore: set seed for flaky tests, use etherscan api key #12255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grandizzy
force-pushed
the
grandizzy/flaky-fuzz-tests
branch
from
b1d8405 to
2ff1c87
Compare
grandizzy
force-pushed
the
grandizzy/flaky-fuzz-tests
branch
2 times, most recently
from
cdb1ca0 to
9bd3ab5
Compare
grandizzy
force-pushed
the
grandizzy/flaky-fuzz-tests
branch
2 times, most recently
from
550a89e to
3fff500
Compare
grandizzy
force-pushed
the
grandizzy/flaky-fuzz-tests
branch
from
3fff500 to
d3ae9bb
Compare
grandizzy
changed the title
grandizzy
requested review from
0xrusowsky,
DaniPopes,
mattsse,
onbjerg and
zerosnacks
as code owners
grandizzy
commented
Oct 23, 2025
| [SEQUENCE] | ||
| invariant_fork_handler_state() ([RUNS]) | ||
| [STATS] |
There was a problem hiding this comment.
suspect some cases where [STATS] redact doesn't work as expected, I trimmed the output only to relevant
grandizzy
commented
Oct 23, 2025
| ... | ||
| Ran 1 test for test/InvariantScrapeValues.t.sol:FindFromReturnValueTest | ||
| [FAIL: value from return found] | ||
| [SEQUENCE] |
There was a problem hiding this comment.
same as above, left only relevant
grandizzy
commented
Oct 23, 2025
| SVM_TARGET_PLATFORM: ${{ matrix.svm_target_platform }} | ||
| HTTP_ARCHIVE_URLS: ${{ secrets.HTTP_ARCHIVE_URLS }} | ||
| WS_ARCHIVE_URLS: ${{ secrets.WS_ARCHIVE_URLS }} | ||
| ETHERSCAN_KEY: ${{ secrets.ETHERSCAN_API_KEY }} |
There was a problem hiding this comment.
if set env var to ETHERSCAN_API_KEY then it's picked up by testdata test wich fails expected config (and other inline tests), hence used different ETHERSCAN_KEY key
0xrusowsky
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Solution
PR Checklist