Skip to content

fix(npm): handle unhandled promise rejection in binary download #12261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2025
+4 −1
Merged

fix(npm): handle unhandled promise rejection in binary download #12261

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion npm/src/install.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,10 @@ if (!PLATFORM_SPECIFIC_PACKAGE_NAME)
// Skip downloading the binary if it was already installed via optionalDependencies
if (!isPlatformSpecificPackageInstalled()) {
console.log('Platform specific package not found. Will manually download binary.')
downloadBinaryFromRegistry()
downloadBinaryFromRegistry().catch(error => {
console.error(colors.red, 'Failed to download binary:', error, colors.reset)
process.exitCode = 1
})
} else {
console.log('Platform specific package already installed. Skipping manual download.')
}
Loading