-
Couldn't load subscription status.
- Fork 2.2k
chore(fmt): prefer_compact + indent bin expr w/ parenthesis #12281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…nto rusowsky/fmt-chores
…nto rusowsky/fmt-chores
68013ca to
f91e1a5
Compare
f91e1a5 to
dc9bc7b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make sense! should we apply prefer compact config to emits and reverts with named args too? e.g. if we don't have preferred compact events then break also emit as
emit WithdrawFromLockupStream({
streamId: ids.defaultStream,
to: users.recipient,
token: dai,
amount: withdrawAmount
});and if we don't prefer compact reverts then break also revert as
revert InsufficientBalance({
balance: bal,
withdrawAmount: _withdrawAmount,
address1: _address,
token: dai,
to: users.recipient
});|
good call, will do it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
|
I think there's one more case that is not covered but we can fix in a follow-up if so - with // Make the withdrawal.
lockup.withdraw{ value: LOCKUP_MIN_FEE_WEI }({
- streamId: differentSenderRecipientStreamId,
- to: address(recipientGood),
- amount: withdrawAmount
+ streamId: differentSenderRecipientStreamId, to: address(recipientGood), amount: withdrawAmount
});
}
} |
…rs#12281) * fix: indentation in operator exprs with parentheses * docs: new param * feat: prefer_compact * fix: test * style: typo * fix: default config test * Fix wrap comments test * fix: emit and revert --------- Co-authored-by: grandizzy <grandizzy.the.egg@gmail.com>
Motivation
call_compact_argsinto an enumprefer_compactto:multiline_func_headerequivalent for events #4024prefer_compact(we forgot to doccall_compact_argswhen added after the migration, so i guess nobody should be using it yet)PR Checklist