refactor(anvil): simplify transaction conversion to RpcTransaction #12391
+60
−86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added TypedTransaction::try_into_eth() to convert TypedTransaction to TxEnvelope, returning an error for Deposit transactions that are not part of standard Ethereum. Added MaybeImpersonatedTransaction::into_rpc_transaction() method that encapsulates the conversion logic, making it more explicit and easier to use. The From<MaybeImpersonatedTransaction> for RpcTransaction trait now delegates to this method. Removed the standalone to_alloy_transaction_with_hash_and_sender function since its logic is now part of the into_rpc_transaction method. Updated transaction_build to use the new into_rpc_transaction() method, simplifying the conversion flow and eliminating redundant recovery calls. Co-Authored-By: Claude <noreply@anthropic.com>
mattsse
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
onbjerg and
zerosnacks
as code owners
grandizzy
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The transaction conversion logic from TypedTransaction to RpcTransaction was spread across multiple functions with significant code duplication. This change consolidates and simplifies the conversion flow.
TypedTransaction now has a try_into_eth() method that converts to TxEnvelope, returning an error for OP-stack Deposit transactions which aren't part of standard Ethereum transaction types.
The new MaybeImpersonatedTransaction::into_rpc_transaction() method encapsulates the entire conversion logic in one place, making the API more explicit and easier to use. The From trait implementation now simply delegates to this method.
The standalone to_alloy_transaction_with_hash_and_sender function has been removed since its logic is now part of the into_rpc_transaction method. This eliminates ~80 lines of duplicated RpcTransaction construction and makes the code easier to maintain.
this is still a bit verbose because we need to inject fake fake hashes for impersonated txs