refactor(anvil): simplify receipt conversion using map_logs #12413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced verbose manual receipt conversion logic with map_logs helper method for cleaner and more maintainable code. The previous implementation manually iterated through logs, created new Vec, and reconstructed the ReceiptWithBloom. The new implementation uses the map_logs helper which does the same thing more concisely. Co-Authored-By: Claude <noreply@anthropic.com>
mattsse
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
onbjerg and
zerosnacks
as code owners
grandizzy
approved these changes
Nov 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies the
convert_receipt_to_rpcfunction by using themap_logshelper method instead of manually reconstructing the receipt.Before:
.into_iter().map().collect()ReceiptWithBloomandReceiptstructsAfter:
receipt.map_logs()helper methodThe functionality is identical - both convert
ReceiptWithBloom<Receipt<alloy_primitives::Log>>toReceiptWithBloom<Receipt<alloy_rpc_types::Log>>by wrapping each log in the RPC type. The new implementation is cleaner and more maintainable.