Skip to content

Reduce redundant RPC cloning in script runner setup #12485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Reduce redundant RPC cloning in script runner setup #12485

wants to merge 1 commit into from

Conversation

@Doryu001
Copy link

@Doryu001 Doryu001 commented Nov 7, 2025

Reuse the original RPC string when returning (rpc, runner) keep the single intentional clone for fork_url and drop the redundant one

DaniPopes added a commit that referenced this pull request Nov 7, 2025
@DaniPopes
chore: aggregate PRs
e4ea956 
This PR aggregates changes from the following PRs:

- Closes #12448 by @\strmfos
- Closes #12465 by @\wedjob0X
- Closes #12485 by @\Doryu001
@DaniPopes DaniPopes mentioned this pull request Nov 7, 2025
Closed
github-merge-queue bot pushed a commit that referenced this pull request Nov 7, 2025
@DaniPopes
chore: aggregate PRs (#12486)
f605826 
This PR aggregates changes from the following PRs:

- Closes #12448 by @\strmfos
- Closes #12465 by @\wedjob0X
- Closes #12485 by @\Doryu001
DaniPopes added a commit that referenced this pull request Nov 7, 2025
@DaniPopes
chore: aggregate PRs
c82a57c 
This PR aggregates changes from the following PRs:

- Closes #12448 by @\strmfos
- Closes #12465 by @\wedjob0X
- Closes #12485 by @\Doryu001
- Closes #12487 by @\kilavvy
- Closes #12492 by @\avorylli
@DaniPopes DaniPopes mentioned this pull request Nov 7, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Nov 7, 2025
@DaniPopes
chore: aggregate PRs (#12493)
a02ee13 
This PR aggregates changes from the following PRs:

- Closes #12448 by @\strmfos
- Closes #12465 by @\wedjob0X
- Closes #12485 by @\Doryu001
- Closes #12487 by @\kilavvy
- Closes #12492 by @\avorylli
@github-project-automation github-project-automation bot moved this to Done in Foundry Nov 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@grandizzy grandizzy Awaiting requested review from grandizzy grandizzy is a code owner

@zerosnacks zerosnacks Awaiting requested review from zerosnacks zerosnacks is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@0xrusowsky 0xrusowsky Awaiting requested review from 0xrusowsky 0xrusowsky is a code owner

Assignees

No one assigned

Labels

None yet

Projects

Foundry
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Doryu001