feat(anvil): add eth_fillTransaction support
#12595
Merged
+257
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced `EthFillTransaction` to handle filling transaction fields with defaults. - Implemented `fill_transaction` method to populate missing fields like nonce, gas limit, and fees. - Added `FillTransactionResult` struct to encapsulate the response of the new RPC method. - Updated tests to verify the functionality of the `fill_transaction` method, ensuring it correctly fills in required fields and preserves provided values.
mablr
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
mattsse,
onbjerg and
zerosnacks
as code owners
mattsse
requested changes
Nov 17, 2025
Comment on lines
+1276
to
+1286
| /// Response type for `eth_fillTransaction` RPC method. | ||
| /// | ||
| /// This type represents a transaction that has been "filled" with default values | ||
| /// for missing fields like nonce, gas limit, and fee parameters. | ||
| #[derive(Debug, Clone, Serialize, Deserialize)] | ||
| pub struct FillTransactionResult<T> { | ||
| /// RLP-encoded transaction bytes | ||
| pub raw: Bytes, | ||
| /// Filled transaction request | ||
| pub tx: T, | ||
| } |
Member
There was a problem hiding this comment.
I think we can now upstream this to allo-eth-rpc
3 tasks
mattsse
approved these changes
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Close #12590
Solution
EthFillTransactionto handle filling transaction fields with defaults.fill_transactionmethod to populate missing fields like nonce, gas limit, and fees.FillTransactionResultstruct to encapsulate the response of the new RPC method.fill_transactionmethod, ensuring it correctly fills in required fields and preserves provided values.heavily inspired from reth impl s/o @kumaryash90
PR Checklist