feat!(forge script): add --interactive flag for deploying with a single keypair
#12608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Dipanshu Singh <58115782+dipanshuhappy@users.noreply.github.com>
zerosnacks
commented
Nov 19, 2025
| signers.extend(mnemonics); | ||
| } | ||
| if self.interactive { | ||
| pending.push(PendingSigner::Interactive); |
Member
Author
There was a problem hiding this comment.
We simply push this in the same pending queue that interactives uses and re-use the existing flow
zerosnacks
commented
Nov 19, 2025
| default_value = "0", | ||
| value_name = "NUM" | ||
| )] | ||
| #[arg(long, help_heading = "Wallet options - raw", default_value = "0", value_name = "NUM")] |
Member
Author
There was a problem hiding this comment.
Note the removal of short, breaking change in favor of interactive carrying the short flag
I think this is worth it for UX consistency, https://github.com/search?q=%22forge+script%22+-i+&type=code shows a few very minor examples in unmaintained repos
zerosnacks
changed the title
forge script): add --interactive flagforge script): add --interactive flag
zerosnacks
changed the title
forge script): add --interactive flagforge script): add --interactive flag for deploying with a single keypair
zerosnacks
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
mattsse and
onbjerg
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Adds
--interactiveflag mirroring current use inRawWalletOptspreventing the user from having to pass--interactives 1 --sender <SENDER_ADDRESS>Difficult to test due to the interactive nature but tested manually
Solution
Closes: #12601
Added @dipanshuhappy as co-author as it was originally assigned to them, took over to unblock myself
PR Checklist
Breaking changes
Uses the
-ishorthand for--interactiveflag mirroring behavior ofRawWalletOptsthat people are used to.Existing users will be faced with error: