feat(anvil): extend Content-Type support on Beacon API #12611
Merged
+181
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Support "application/octet-stream" and "application/json" content types - Implemented `must_be_ssz` helper to determine if the Accept header prefers SSZ encoding. - Updated `handle_get_blobs` to return SSZ-encoded blobs when requested. - Enhanced tests to verify both JSON and SSZ responses for blob sidecars. - Added accept header assertions in tests to ensure correct content type selection.
mablr
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
mattsse,
onbjerg and
zerosnacks
as code owners
grandizzy
reviewed
Nov 19, 2025
Collaborator
grandizzy
left a comment
grandizzy
left a comment
There was a problem hiding this comment.
thank you, lgtm, left couple of comments
|
|
||
| /// Helper function to determine if the Accept header indicates a preference for SSZ (octet-stream) | ||
| /// over JSON. | ||
| pub fn must_be_ssz(headers: &HeaderMap) -> bool { |
Collaborator
There was a problem hiding this comment.
nit: shouldn't be public
Contributor
Author
There was a problem hiding this comment.
This was merged too fast 😅
I may fix it as a follow-up. Btw Anvil's server module can be split/reorganized for clarity:
- crates/anvil/src/server/mod.rs
- crates/anvil/src/server/beacon/
- crates/anvil/src/server/rpc/
I can wrap it all in one PR.
Collaborator
There was a problem hiding this comment.
thank you! yeah not a prio, can include in future PR
| let mut json_q = 0.0; | ||
|
|
||
| // Parse each media type in the Accept header | ||
| for media_type in accept_str.split(',') { |
Collaborator
There was a problem hiding this comment.
should we worry if same media type present multiple times? (I think that's technically allowed) - probably not an issue as we'll consider the last one
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Close #12610
Solution
must_be_sszhelper to determine if the Accept header prefers SSZ encoding.handle_get_blobsto return SSZ-encoded blobs when requested.PR Checklist