refactor(anvil): simplify effective_reward calculation in FeeHistoryService
#12640
+10
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ryService::create_cache_entry` - cleanup useless casts - more elegant default rewards array
mablr
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
mattsse,
onbjerg and
zerosnacks
as code owners
mattsse
approved these changes
Nov 23, 2025
Member
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
cool, yeah this is equivalent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Anvil cleanup in the same vein as #12639 + smol nits
However, I created this PR separately as I’m not entirely certain that this one isn’t breaking, so it requires a more thorough review.
Imo Alloy's helper has the same logic as anvil's custom one https://github.com/alloy-rs/alloy/blob/9770720d77000d48c9d1f9979bf393f3b09b118b/crates/eips/src/eip1559/helpers.rs#L14-L30
Solution
Transaction::effective_tip_per_gas()base_feecasts, only one is necessary u64->u128, instead of u64->u128->u64vec![]instead of heavy.iter().map().collect()PR Checklist