feat: forge verify-bytecode should automatically recompile upon running #12651
+65
−53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jds-23
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
mattsse,
onbjerg and
zerosnacks
as code owners
Author
|
I tried running: make build
make prMany tests were failing before my change, most not related to my change. Is there a guide to run all testcases smoothly? |
Collaborator
@Jds-23 just kicked CI and all seems good, you probably experience issues locally due to etherscan and other providers rate limiting |
grandizzy
requested changes
Nov 25, 2025
Collaborator
grandizzy
left a comment
grandizzy
left a comment
There was a problem hiding this comment.
I think this makes sense, small nit re test. pending @zerosnacks
grandizzy
previously requested changes
Nov 26, 2025
zerosnacks
approved these changes
Nov 26, 2025
Member
zerosnacks
left a comment
zerosnacks
left a comment
There was a problem hiding this comment.
Makes sense, updated PR to inline the test
zerosnacks
changed the title
grandizzy
approved these changes
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #12644
Motivation
Solution
Removed the code that checks for a cache and builds from it in
crates/verify/src/bytecode.rs.Added test that validates recompilation on source change: Builds with correct source (creates cache), replaces source with different code, runs verify-bytecode which recompiles (not using stale cache) and detects bytecode mismatch.
I consulted Claude Code to understand the codebase, but the solution was fully authored manually by me.
PR Checklist