Skip to content

Conversation

@onbjerg
Copy link
Contributor

@onbjerg onbjerg commented Apr 11, 2022

Motivation

The output of -h and --help is inconsistent and sometimes not super helpful.

Solution

Goes through all help text and updates the wording. I also move some of the longer-form help text into long_help to shorten the output of -h.

I'm going through this as I am rewriting the command references in the book.

Tasks

  • Go through the rest of Cast
  • Go through the rest of Forge
  • Be consistent with the help text of function signatures and block tags
  • Note down commands that are good candidates for merging
  • Improve docs on Wallet struct
  • Remove unused options in each command (deferred to Clean up CLI commands and options #1274)
  • Link to the book at the end of -h/--help

@onbjerg onbjerg added the L-ignore Log: ignore PR in changelog label Apr 11, 2022
@onbjerg onbjerg force-pushed the onbjerg/help-improvements branch from 0119e2e to cfb385d Compare April 11, 2022 17:07
@onbjerg onbjerg force-pushed the onbjerg/help-improvements branch from 749330a to 77cc49f Compare April 12, 2022 04:06
@onbjerg onbjerg force-pushed the onbjerg/help-improvements branch 5 times, most recently from 2df53f9 to c684302 Compare April 14, 2022 07:43
@onbjerg onbjerg force-pushed the onbjerg/help-improvements branch from d7e0f0c to 5b87e90 Compare April 14, 2022 12:12
@onbjerg onbjerg marked this pull request as ready for review April 14, 2022 12:12
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm,

like the breakdown of buildargs

pub force: bool,
pub via_ir: bool,

#[clap(flatten, next_help_heading = "PROJECT OPTIONS")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe PROJECT LAYOUT/DIR OPTIONS ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can do in a follow up PR

@onbjerg onbjerg merged commit a5e58ad into master Apr 14, 2022
@onbjerg onbjerg deleted the onbjerg/help-improvements branch April 14, 2022 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

L-ignore Log: ignore PR in changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants