refactor: etherscan #3395
Merged
refactor: etherscan #3395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
mattsse
approved these changes
Sep 29, 2022
DaniPopes
commented
Sep 29, 2022
| for item in &contract_source.items { | ||
| abis.push(serde_json::from_str(&item.abi)?); | ||
| } | ||
| // TODO: Abi to RawAbi ? |
Member
Author
There was a problem hiding this comment.
@mattsse not sure how to do this here, metadata's abi field is an Abi struct when we need a RawAbi, reasons explained in foundry_utils::abi::abi_to_solidity
Member
There was a problem hiding this comment.
ah sigh, we need to change this back to either string or RawAbi, because Abi is not lossless
Member
There was a problem hiding this comment.
also suggesting that we move RawAbi to ethers-core
I'd change the abi field to String and add helper functions that return RawAbi and Abi, I think
iFrostizz
pushed a commit
to iFrostizz/foundry
that referenced
this pull request
Nov 9, 2022
* fix: docs * refactor: etherscan * feat: add etherscan recursive source find method * chore(deps): bump ethers * enable feature * chore(clippy): make clippy happy Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Blocked by: gakonst/ethers-rs#1747
Solution