Skip to content

Conversation

@DaniPopes
Copy link
Member

@DaniPopes DaniPopes commented Aug 11, 2023

Reduce compilation times and binary bloat.

  1. Isolate forge and cast CLI args from each other since they do not share almost any code. (7e8ebdc)

  2. The code they do share is extracted into foundry-cli. This is just CoreBuildArgs and ProjectPathsArgs from cmd::forge::build. (539f9d0)

Before:

cli/src
├── cast.rs      <--
├── cmd
│   ├── cast     <--
│   ├── forge    <--
│   └── ...
├── forge.rs     <--
├── opts
│   ├── cast.rs  <--
│   ├── forge.rs <--
│   └── ...
└── ...

After:

cli/src
├── cast  <--
│   ├── cmd
│   ├── main.rs
│   └── opts.rs
├── forge <--
│   ├── cmd
│   ├── main.rs
│   └── opts.rs
└── ...

@Evalir Evalir requested review from Evalir and mattsse August 11, 2023 01:59
Copy link
Member

@Evalir Evalir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love this! pending @mattsse

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this,

unfortunately, this also needs a rebase

@DaniPopes
Copy link
Member Author

Re Based

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse mattsse merged commit 38f6ccf into foundry-rs:master Aug 11, 2023
@DaniPopes DaniPopes deleted the split-cli-bins branch August 11, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants