chore: crates/ directory #5597
Merged
chore: crates/ directory #5597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
force-pushed
the
crates
branch
3 times, most recently
from
992b946 to
58bd0be
Compare
Evalir
approved these changes
Aug 11, 2023
Member
Evalir
left a comment
Evalir
left a comment
There was a problem hiding this comment.
as soon as ci is green this is good imo. let's make the flattening happen
Member
|
deferring to @mattsse for final merge |
mattsse
requested changes
Aug 11, 2023
Member
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
ah yikes, I only saw this one now after merging some other prs...
so there are a few conflicts unfortunately, sorry about that
requires rebase
DaniPopes
force-pushed
the
crates
branch
2 times, most recently
from
37b3c13 to
ac42114
Compare
mattsse
approved these changes
Aug 11, 2023
Member
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
long overdue,
this will introduce conflicts in open prs, but those should be easily fixable, since this simply moves the files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
crates/../testdata/with../../testdataSolution