Skip to content

Conversation

@Evalir
Copy link
Member

@Evalir Evalir commented Aug 11, 2023

Motivation

Solution

@Evalir Evalir requested a review from mattsse August 12, 2023 02:42
mattsse
mattsse previously approved these changes Aug 12, 2023
@mattsse
Copy link
Member

mattsse commented Aug 12, 2023

test / external integration tests / forking (pull_request) Successful in 59m

oh this runs for an hour ...

we should move this to another job and maybe only run on merge or once a day and open issue if fails, because this runs forever on PRs

@mattsse mattsse dismissed their stale review August 12, 2023 11:16

will clog CI

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this repo is huge and will take forever, so we need a new ci job for this think

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we get an issue if this fails?

@Evalir
Copy link
Member Author

Evalir commented Aug 16, 2023

yep: see 89d6012

@Evalir Evalir requested a review from mattsse August 16, 2023 00:12
@Evalir Evalir merged commit d154507 into master Aug 16, 2023
@Evalir Evalir deleted the evalir/add-maple branch August 16, 2023 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants