chore(cli): remove Cmd trait
#5614
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
force-pushed
the
rm-cmd
branch
2 times, most recently
from
80716ee to
d7ca338
Compare
mattsse
approved these changes
Aug 12, 2023
mattsse
approved these changes
Aug 12, 2023
Evalir
approved these changes
Aug 12, 2023
Member
Evalir
left a comment
Evalir
left a comment
There was a problem hiding this comment.
nice. yeah, the cmd.run() pattern's pretty rad just doesn't need a trait.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is an unnecessary abstraction, and also all async commands do not implement it anyway.
Solution
Remove it and just have public
runfunctions