test: speed up some tests #5654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
approved these changes
Aug 17, 2023
Evalir
approved these changes
Aug 17, 2023
Member
Evalir
left a comment
Evalir
left a comment
There was a problem hiding this comment.
nice catch! yep, we should take a look at how to speed up forge tests in general so CI is faster
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Unit tests are held hostage for 30s+ by a single keystore test because the key derivation crate is not optimized, and some create2 tests
Forge tests spend a lot of time cloning the compiler output, something to take note of (
(*COMPILED).clone()) cc @EvalirSolution