fix(common): ipc provider windows #5831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
reviewed
Sep 14, 2023
| fn resolve_path(path: &Path) -> Result<PathBuf, ()> { | ||
| let path_str = path.to_str().expect("Path should be a valid string"); | ||
|
|
||
| if path_str.starts_with(r"\\.\pipe\") { |
Contributor
Author
There was a problem hiding this comment.
Yes. IPC on Windows don't have regular files like on Unix and always start with the Path \\.\pipe\
https://learn.microsoft.com/en-us/windows/win32/api/winbase/nf-winbase-createnamedpipea
https://geth.ethereum.org/docs/interacting-with-geth/rpc#ipc-server
mattsse
approved these changes
Sep 14, 2023
This reverts commit a4f39a0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Noticed that the CI for Windows builds fails for integration tests using IPC provider.
Solution
Handle
\\.\pipe\paths correctly on Windows.Need to revert changes to CI before merging, just there for review.