Skip to content

fix(coverage): require should be branch #8433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 13, 2024
Merged

fix(coverage): require should be branch #8433

merged 1 commit into from
Jul 13, 2024
+100 −9

Conversation

@grandizzy
Copy link
Collaborator

Motivation

Closes #8423

Solution

  • treat require as branch coverage
  • test

@grandizzy grandizzy marked this pull request as ready for review July 13, 2024 12:35
mattsse
mattsse approved these changes Jul 13, 2024
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@grandizzy grandizzy merged commit 5902a6f into foundry-rs:master Jul 13, 2024
@grandizzy grandizzy deleted the issue-8423 branch July 13, 2024 14:47
@grandizzy grandizzy mentioned this pull request Nov 30, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattsse mattsse mattsse approved these changes

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@Evalir Evalir Awaiting requested review from Evalir

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

coverage: require should be a branch

2 participants

@grandizzy @mattsse