fix(fork): preserve block number and timestamp when changing fork #8466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
approved these changes
Jul 18, 2024
Comment on lines
+305
to
+312
| /// Update fork block number and timestamp. Used to preserve values set by `roll` and `warp` | ||
| /// cheatcodes when new fork selected. | ||
| fn update_block(&mut self, fork_id: ForkId, block_number: U256, block_timestamp: U256) { | ||
| if let Some(fork) = self.forks.get_mut(&fork_id) { | ||
| fork.opts.env.block.number = block_number; | ||
| fork.opts.env.block.timestamp = block_timestamp; | ||
| } | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #8168
Fork's block number and timestamp can be changed using
vm.warpandvm.rollbut they're not preserved in a multifork setup when a different fork is selected.Solution