fix(verify-bytecode): fix metadata extraction and add tests #8560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
approved these changes
Jul 30, 2024
crates/verify/src/bytecode.rs
Outdated
| } | ||
|
|
||
| #[cfg(test)] | ||
| mod tests { |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8555
Instead of relying on
Configto determine whether we need to strip metadata, we now just look at the end of the bytecode and try decoding it into CBOR as suggested by @mds1 in #8555 (comment). If decoding succeeds, we strip the suffixI've also added tests and a helper to add them. Tests are simply running
cast etherscan-source --flattenand then try to verify compiled downloaded source against on-chain bytecode.