Skip to content

fix(coverage): relax deployed bytecode accepted score #8657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 13, 2024
Merged

fix(coverage): relax deployed bytecode accepted score #8657

merged 1 commit into from
Aug 13, 2024

Conversation

@grandizzy
Copy link
Collaborator

@grandizzy grandizzy commented Aug 13, 2024 •
edited
Loading

Motivation

repro of issue https://github.com/grandizzy/coverage-immutables-repro
Coverage not properly match by deployed bytecode when contract has immutables

Solution

  • parametrize accepted score, keep 0.1 for creation code and bump to 0.15 for deployed code (in provided repro matched score of 0.11235)

@grandizzy grandizzy changed the title fix(coverage): relax deployed code match score fix(coverage): relax deployed bytecode match score Aug 13, 2024
@grandizzy grandizzy changed the title fix(coverage): relax deployed bytecode match score fix(coverage): relax deployed bytecode accepted score Aug 13, 2024
@grandizzy grandizzy marked this pull request as ready for review August 13, 2024 15:38
@grandizzy grandizzy requested review from klkvr and removed request for DaniPopes, Evalir and mattsse August 13, 2024 15:38
@DaniPopes DaniPopes merged commit 1c71ab1 into foundry-rs:master Aug 13, 2024
@grandizzy grandizzy deleted the find-deployed-code branch August 13, 2024 15:44
jurajpiar pushed a commit to jurajpiar/foundry that referenced this pull request Aug 13, 2024
@grandizzy @jurajpiar
fix(coverage): relax deployed bytecode accepted score (foundry-rs#8657)
3aeef78
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaniPopes DaniPopes DaniPopes approved these changes

@klkvr klkvr Awaiting requested review from klkvr

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@grandizzy @DaniPopes