Skip to content

fix: update formatting for fixed bytes #8687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 17, 2024
Merged

fix: update formatting for fixed bytes #8687

merged 2 commits into from
Aug 17, 2024

Conversation

@klkvr
Copy link
Member

@klkvr klkvr commented Aug 17, 2024

Motivation

ref #8682 (comment)

Updates formatting for fixed bytes to remove padding with zero bytes

Solution

@klkvr
Copy link
Member Author

klkvr commented Aug 17, 2024

also removed alloy-node-bindings from workspace deps as we're not using it anywhere and cargo complains about an unused patch

@DaniPopes DaniPopes merged commit 0bb5864 into master Aug 17, 2024
@DaniPopes DaniPopes deleted the klkvr/fixed-bytes-format branch August 17, 2024 16:53
@yash-atreya yash-atreya mentioned this pull request Sep 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaniPopes DaniPopes DaniPopes approved these changes

@Evalir Evalir Awaiting requested review from Evalir

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@klkvr @DaniPopes