fix(anvil): storage diff #8691
Merged
fix(anvil): storage diff #8691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I don't think I broke CI as it just seems to be a HTTP error but let me know if I need to fix something |
klkvr
approved these changes
Aug 19, 2024
Member
klkvr
left a comment
klkvr
left a comment
There was a problem hiding this comment.
Confirming this resolves the issue. Enabling it with --steps-tracing should be fine as storage diffs are not that heavy compared to complete steps trace
Evalir
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Tries to resolve #8688. This issue was discovered when performing some tests with the
debug_traceTransactionendpoint which seemed to fail to return any storage diffs created by a transaction.Solution
Add the call to
with_state_diffs()when creating theTracingInspectorConfig::all()which doesn't include the state diffs.